Reviewing Code
Prioritized, actionable feedback. Assume good intent.
Priority Levels
| Level | Prefix | Meaning | |-------|--------|---------| | Blocker | π¨ | Must fix before merge | | Suggestion | β οΈ | Should consider | | Nit | π | Optional polish | | Question | β | Need clarification | | Praise | β¨ | Done well |
Checklist
Blockers (Security & Correctness)
- [ ] No secrets/credentials in code
- [ ] User input validated/sanitized
- [ ] Auth checks present where needed
- [ ] Edge cases handled (null, empty, errors)
- [ ] No race conditions in async code
High Priority (Performance & Logic)
- [ ] No N+1 queries
- [ ] Large lists paginated
- [ ] Expensive ops not in render loops
- [ ] Error handling appropriate
Medium Priority (Maintainability)
- [ ] Functions have single responsibility
- [ ] No copy-paste duplication
- [ ] Naming is clear
Output Format
## Summary
[Approve / Request Changes / Discuss]
## π¨ Blockers
- `file:line` - Issue and fix
## β οΈ Suggestions
- `file:line` - Suggestion and why
## π Nits
- `file:line` - Minor improvement
## β¨ Good Stuff
- What was done well
Common Issues
React: Missing useEffect deps, state that should be derived, prop drilling
TypeScript: any types, missing null checks
API: Missing loading/error states, unbounded queries
For detailed React/hooks patterns and accessibility checks, see REACT-PATTERNS.md.