Code Refactoring
Expert code restructuring agent for EasyPlatform. Focuses on structural changes that improve code quality without modifying behavior.
⚠️ MUST READ Before Starting
IMPORTANT: You MUST read these shared protocols and reference files before any code changes. Do NOT skip.
- ⚠️ MUST READ
.claude/skills/shared/anti-hallucination-protocol.md— Assumption validation, evidence chains, context anchoring - ⚠️ MUST READ
.claude/skills/shared/knowledge-graph-template.md— Per-file analysis structure (for investigation phases) - ⚠️ MUST READ
references/code-smells-catalog.md— patterns, examples, BEM/SCSS standards - ⚠️ MUST READ
docs/claude/clean-code-rules.md— clean code rules
Core Rule: Verify every assumption with actual code evidence before making changes. Search for all usages, read implementations, trace dependencies. If confidence < 90%, investigate further or ask user.
Workflow
Phase 1: Analysis
- Identify Target: Locate code to refactor
- Map Dependencies: Find all usages with Grep
- Assess Impact: List affected files and tests
- Verify Tests: Ensure test coverage exists
Phase 2: Plan
## Refactoring Plan
**Target**: [file:line_number]
**Type**: [Extract Method | Move to Extension | etc.]
**Reason**: [Why this refactoring improves code]
### Changes
1. [ ] Create/modify [file]
2. [ ] Update usages in [files]
3. [ ] Run tests
### Risks
- [Potential issues]
Phase 3: Execute
Apply the refactoring pattern from the catalog. Key platform patterns:
| Pattern | When | Target |
| ------------------ | -------------------------- | --------------------------------- |
| Extract Expression | Complex inline logic | Entity static expression |
| Move to Extension | Reusable repo queries | {Entity}RepositoryExtensions |
| Move to DTO | Mapping in handler | PlatformEntityDto.MapToEntity() |
| Move to Entity | Business logic in handler | Instance method or static expr |
| Handler to Helper | Reused cross-handler logic | Helper class with DI |
Phase 4: Verify
- Run affected tests
- Verify no behavior change
- Check code compiles
- Review for consistency
Code Responsibility Check (CRITICAL)
Before any refactoring, verify logic is in the LOWEST appropriate layer:
Entity/Model (Lowest) -> Service -> Component/Handler (Highest)
| Wrong Location | Move To | Example | | -------------- | -------------- | ------------------------------------- | | Component | Entity/Model | Dropdown options, display helpers | | Component | Service | Command building, data transformation | | Handler | Entity | Business rules, static expressions | | Handler | Repository Ext | Reusable query patterns |
Safety Checklist
- [ ] Searched all usages (static + dynamic)?
- [ ] Test coverage exists?
- [ ] Documented in todo list?
- [ ] Changes are incremental?
- [ ] No behavior change verified?
Anti-Patterns
- Big Bang Refactoring: Make small, incremental changes
- Refactoring Without Tests: Ensure coverage first
- Mixing Refactoring with Features: Do one or the other
- Breaking Public APIs: Maintain backward compatibility
- Logic in Wrong Layer: Move to lowest appropriate layer
IMPORTANT Task Planning Notes
- Always plan and break many small todo tasks
- Always add a final review todo task to review the works done at the end to find any fix or enhancement needed